Don't use ReadableStream as an asyncIterator#5144
Queued
coolreader18 wants to merge 1 commit into
Queued
Conversation
joshua-spacetime
approved these changes
Jun 1, 2026
Contributor
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
Were you able to verify on the applicable safari and chrome versions?
Contributor
Author
|
Not on safari, but yes on chrome and firefox. |
Contributor
|
I was able to test on Safari |
Any commits made after this event will not be merged.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Reverts part of #4561. Fixes an issue with
ReadableStream[Symbol.asyncIterator]not being defined on safari until recently.Expected complexity level and risk
1
Testing
.withCompression('gzip'))